fix: nix packaging#147
Open
es-sai-fi wants to merge 1 commit into
Open
Conversation
Contributor
Greptile SummaryThis PR fixes Nix packaging by splitting the legacy
|
| Filename | Overview |
|---|---|
| package.nix | Fixes Nix packaging: splits name into pname+version, removes allowBuiltinFetchGit (safe — no git-sourced deps in Cargo.lock), and injects VERGEN env vars so the binary reports consistent version info at build time. |
| .gitignore | Adds /result to ignore the Nix build symlink, addressing the issue raised in the previous review thread. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["nix build"] --> B["rustPlatform.buildRustPackage"]
B --> C["Fetch src = ./."]
C --> D["Resolve cargoLock.lockFile = ./Cargo.lock"]
D --> E["Set env vars\nVERGEN_GIT_DESCRIBE=dev\nVERGEN_BUILD_DATE=unknown"]
E --> F["cargo build --release"]
F --> G["/nix/store/...-gitv-dev\n bin/gitv"]
G --> H["result symlink\n(ignored by .gitignore)"]
Reviews (5): Last reviewed commit: "fix: nix packaging" | Re-trigger Greptile
4bc8eb2 to
1db2141
Compare
Contributor
Author
|
I removed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #146.